chore: add LICENSE and transfer PyPI ownership#20
chore: add LICENSE and transfer PyPI ownership#20cusell-google wants to merge 5 commits intoUniversal-Commerce-Protocol:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on establishing proper licensing and updating package metadata for the UCP Python SDK. It ensures that the project explicitly states its Apache 2.0 license and prepares the package for better distribution and identification on PyPI by enriching its configuration with relevant classifiers and updating the primary author for ownership transfer purposes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a license file and updates the pyproject.toml with new metadata, including classifiers and a change of authorship. While the updates to pyproject.toml are beneficial, there is a significant issue in the LICENSE file. The copyright year has been set to 2026, a future date, which is legally incorrect and should be updated to the current year.
pyproject.toml
Outdated
| license = {file = "LICENSE"} | ||
| authors = [ | ||
| { name = "Florin Iucha", email = "fiucha@google.com" } | ||
| { name = "Enric Cusell", email = "cusell@google.com" } |
There was a problem hiding this comment.
Nit: could we get at least 1 more person for coverage?
There was a problem hiding this comment.
keeping Florin and adding myself. I'll update it further with another contributor.
|
Merged which had conflicts, updated with 2 authors: Federico D'Amato and Enric Cusell. |
This PR adds a LICENSE and handles the transition of the PyPI package ownership as a temporary approach until we find a generic group or alias.