fix: Update python server /samples to UCP 01-23 version.#66
Open
cusell-google wants to merge 9 commits intoUniversal-Commerce-Protocol:mainfrom
Open
fix: Update python server /samples to UCP 01-23 version.#66cusell-google wants to merge 9 commits intoUniversal-Commerce-Protocol:mainfrom
cusell-google wants to merge 9 commits intoUniversal-Commerce-Protocol:mainfrom
Conversation
cusell-google
requested review from
MitkoDeyanovMitev,
knightlin-shopify,
ptiper and
richmolj
damaz91
reviewed
Mar 18, 2026
| payment_data=payment_instrument.PaymentInstrument(root=instrument), | ||
| risk_signals={}, | ||
| ) | ||
| return { |
Contributor
There was a problem hiding this comment.
can you explain the rationale?
Author
There was a problem hiding this comment.
The client post (lines 306-310) require the direct json object or a dictionary. They don't serialize pydantic models, so if we the method returns a class here it would need to be converted or unpacked with "model_dump" like it was before. This is cleaner as it avoids the double conversion.
…json for payment payload
cusell-google
changed the title
cusell-google
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update python server /samples to UCP 01-23 version.