-
Notifications
You must be signed in to change notification settings - Fork 315
feat!: update Order capability #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
richmolj
wants to merge
7
commits into
main
Choose a base branch
from
lr/order-spec-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+977
−1,153
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8e42152
fix(order): soften append-only and immutable language on adjustments …
richmolj d10b1e4
fix(order): remove quantity derivation language
richmolj 29a3fa1
feat(order): model Order:Checkout as 1:N relationship
richmolj fc7239b
feat(order): signed quantities/amounts, net exchange amounts, quantit…
richmolj 6039caf
fix(order): rename adjustment amount to totals for consistency
richmolj 66f6dbf
fix(order): use signed_amount type for adjustment totals instead of r…
richmolj 493a073
fix(order): compose adjustment totals from total.json with signed_amo…
richmolj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With order edits now in the picture, can we add a guideline around what
line_itemsSHOULD include post these changes, is it:OR
My hunch is that 1) is more comprehensive from a data/audit perspective given there may have been
adjustmentsthat reference back to these altered products?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option 1 - comprehensive list. Line items should include all items that ever existed on the order, even if altered/removed via an edit. This is why
quantity.originalexists on line items - it preserves what was originally ordered at checkout, even whenquantity.totalchanges to 0 after an edit. Adjustments can then always reference back to these items.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, makes sense, is it possible to actually add this on top of this bullet here?
i.e. Something along the lines of
; **MUST** include all line items that ever existed on the order regardless of edits or alterations?