Always download and install the latest URCap(X) if not present #301
Conversation
urfeex
force-pushed
the
download_latest_urcap(x)
branch
from
35c96dd to
29d2902
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
==========================================
- Coverage 75.00% 74.90% -0.11%
==========================================
Files 86 86
Lines 3657 3666 +9
Branches 416 416
==========================================
+ Hits 2743 2746 +3
- Misses 695 703 +8
+ Partials 219 217 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -214,6 +214,14 @@ post_setup_e-series() | |||
|
|
|||
| post_setup_polyscopex() | |||
| { | |||
| urcapx_download_url=$(curl -s https://api.github.com/repos/UniversalRobots/Universal_Robots_ExternalControl_URCapX/releases/latest | grep "browser_download_url.*urcapx" | cut -d ":" -f 2,3 | tr -d "\"[:space:]") | |||
| URCAPX_VERSION=$(echo "$urcapx_download_url" | grep -oP '\d+\.\d+\.\d+' | head -n 1) | |||
There was a problem hiding this comment.
Do we want to add a URCAPX version argument as well or do we wait until there are multiple versions?
There was a problem hiding this comment.
I think I would rather not have one at all. In the past, we had it as we didn't pull the latest version from the Github release page. I would have even removed the other one, but left it there if anybody was actively using that.
There was a problem hiding this comment.
I am fine with leaving it out for know. I guess that we could end up in a situation where different releases of the URCap only work for specific releases of PolyscopeX, but then we can always add it later if that becomes a problem.
Downloads the latest version of https://github.com/UniversalRobots/Universal_Robots_ExternalControl_URCap/releases or https://github.com/UniversalRobots/Universal_Robots_ExternalControl_URCapX/releases/tag/0.1.0 and install that on the URSim container while starting.