feat: allow payload compression in POST requests#170
Conversation
Pull Request Test Coverage Report for Build 8247551100Details
💛 - Coveralls |
sighphyre
left a comment
There was a problem hiding this comment.
Meant to respond last night but I needed to check some stuff!
So we do do support Gzip compression on the metrics endpoints (not formally tested so we'll need to poke the Unleash server to confirm). So this is a nice change
Some initial thoughts - this trades CPU for data transfer. No idea how good Ruby's Gzip compression is (imagine that's C behind the scenes?) but will this be worth it for very small payloads?
The mucking about with mutable state seems unfortunate (add/remove headers dynamically). Can we do this in a cleaner way? Something like provide a use_compression property on the config?
- only done if custom_http_headers config includes {'Content-Encoding' => 'gzip'}
- only allow gzip.
- 'Content-Encoding' header will get dropped in GET requests.
- undocumented feature.
b6b548a to
a4189de
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
About the changes
Discussion points
Creating as a draft PR to gather feedback.