-
Notifications
You must be signed in to change notification settings - Fork 52
Setup Codeflash Github Actions to optimize all future code #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5f98ea2
codeflash workflow for unstructured-ingest
aseembits93 f1cf925
Merge branch 'main' into codeflash-ci
aseembits93 72592ff
pyproject config
aseembits93 9eb50b9
install codeflash before uv run
aseembits93 ab20d73
end with newline
aseembits93 60a575e
Merge branch 'main' into codeflash-ci
aseembits93 51f82c4
Update codeflash.yml
aseembits93 af3e58e
Merge branch 'main' into codeflash-ci
aseembits93 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,39 @@ | ||||
| name: Codeflash / Optimize new Python code | ||||
|
|
||||
| on: | ||||
| pull_request: | ||||
| paths: | ||||
| - 'unstructured_ingest/**' | ||||
|
|
||||
|
|
||||
| concurrency: | ||||
| group: "${{ github.workflow }}-${{ github.ref }}" | ||||
| cancel-in-progress: true | ||||
|
|
||||
|
|
||||
| jobs: | ||||
| optimize: | ||||
| name: Codeflash / Optimize new Python code | ||||
| if: ${{ github.actor != 'codeflash-ai[bot]' }} | ||||
| runs-on: ubuntu-latest | ||||
| env: | ||||
| CODEFLASH_API_KEY: ${{ secrets.CODEFLASH_API_KEY }} | ||||
| NLTK_DATA: ${{ github.workspace }}/nltk_data | ||||
| steps: | ||||
| - uses: 'actions/checkout@v4' | ||||
| - name: Install uv | ||||
| uses: astral-sh/setup-uv@v5 | ||||
| with: | ||||
| enable-cache: true | ||||
| python-version: 3.12 | ||||
|
|
||||
| - name: Set up Python | ||||
| run: uv python install | ||||
|
|
||||
| - name: Codeflash | ||||
| run: | | ||||
| uv sync --all-groups --all-extras --upgrade | ||||
| uv pip install unstructured | ||||
| uv pip install codeflash | ||||
| uv run python -m nltk.downloader -d $NLTK_DATA punkt_tab averaged_perceptron_tagger_eng | ||||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. assuming we need nltk.downloader as a requirement for unstructured? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's needed for the unit tests in
|
||||
| uv run codeflash | ||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this uv sync line may cause a pretty big install. lets keep an eye on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were a bit conservative in the dependency installation stage to ensure all unit tests pass when codeflash is run. We'll be monitoring the logs in github actions to reduce it going forward.