Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix build reproducibility. #3712

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: Fix build reproducibility. #3712

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c76e26
build: Fix build reproducibility.
jsirois Oct 9, 2024
6478c32
Merge branch 'main' into reprocibility/fix
jsirois Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def load_requirements(file_list: Optional[Union[str, List[str]]] = None) -> List
tsv_reqs = load_requirements("requirements/extra-csv.in")
xlsx_reqs = load_requirements("requirements/extra-xlsx.in")

all_doc_reqs = list(
all_doc_reqs = sorted(
Copy link
Author

@jsirois jsirois Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I added no reproducibility test to this repo, the Pex repo now has one inspired directly by the prior list(set(...)) construction. That test failed prior to Pex plumbing PYTHONHASHSEED=0 to all process where distributions are built: https://github.com/pex-tool/pex/pull/2554/files#diff-e405a0e10bc9facaca309df6d749de036226214e787bbcbc05ca0aa2f088bb95

set(
csv_reqs
+ docx_reqs
Expand Down