Unit test

.github/workflows/build_and_functional_tests.yml

@@ -12,11 +12,9 @@ on:
   workflow_dispatch:
   push:
     branches:
-      - master
-      - main
-      - develop
+      - babylon
   pull_request:
-
+    
 jobs:
   build_application:
     name: Build application using the reusable workflow

.github/workflows/ci-workflow.yml

@@ -4,12 +4,9 @@ on:
   workflow_dispatch:
   push:
     branches:
-    - master
-    - develop
+      - babylon
   pull_request:
-    branches:
-    - master
-    - develop
+
 
 jobs:
   job_build:

.github/workflows/codeql-workflow.yml

@@ -4,12 +4,9 @@ on:
   workflow_dispatch:
   push:
     branches:
-      - master
-      - develop
+      - babylon
   pull_request:
-    branches:
-      - master
-      - develop
+
 
 jobs:
   analyse:

.github/workflows/guidelines-enforcer.yml

@@ -12,8 +12,7 @@ on:
   workflow_dispatch:
   push:
     branches:
-      - master
-      - develop
+      - babylon
   pull_request:
 
 jobs:

.github/workflows/lint-workflow.yml

@@ -11,9 +11,7 @@
     workflow_dispatch:
     push:
       branches:
-        - master
-        - main
-        - develop
+        - babylon
     pull_request:
 
   jobs:

.github/workflows/unit-test.yml

@@ -0,0 +1,26 @@
+name: Unit
+
+on:
+  workflow_dispatch:
+  push:
+    branches:
+    - babylon
+    - unit-test
+  pull_request:
+
+jobs:
+    job_unit_test:
+        name: Unit test
+        runs-on: ubuntu-latest
+
+        container:
+            image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder:latest
+
+        steps:
+        - name: Clone
+          uses: actions/checkout@v4
+
+        - name: Build and Run unit tests
+          run: |
+            cd unit-tests/
+            cmake -Bbuild -H. && make -C build && make -C build test

doc/coinspect.md

@@ -0,0 +1,15 @@
+# Bug Tracking Table
+
+| NO  | LEVEL  | NAME                                          | comment                                   | solution                                    |
+|-----|--------|-----------------------------------------------|-------------------------------------------|---------------------------------------------|
+| 1   | LOW    | Buffer overrun                                | Ledger's musigsession_commit code        | Done. Delete all musig code                |
+| 2   | HIGH   | Removed validation checks                     | fix April 3th  105a8c0                   | Done.                                      |
+| 3   | HIGH   | Insecure policy name matching                 |                                           | Done. Add new function to check descriptor |
+| 4   | Medium | Infinite point check missing                  | Ledger's musig code                      | Done. Delete all musig code                |
+| 5   | LOW    | Outdated documentation                        |                                           | Done. As recommendation                    |
+| 6   | LOW    | Hardcoded constants                           | Ledger's musig Hardcoded                 | Done. Delete all musig code                |
+| 7   | LOW    | Insecure string copying                       | Ledger's UI code                         | Suggest to ignore                          |
+| 8   | HIGH   | Lack of fee and output validations            | There are ways to do validations         | Please search ‘BAP-008’ in code            |
+| 9   | LOW    | flawed fingerprint policy                     | fingerprint has special using            | Please search ‘BAP-009’ in code            |
+| 10  | LOW    | Insufficient input validation                 | There are ways to do validations         | Please search ‘BAP-010’ in code            |
+| 11  | HIGH   | Insufficient SIGHASH TYPE enforcement         |                                           | Done. As recommendation                    |

src/boilerplate/dispatcher.c

@@ -88,16 +88,16 @@ static int process_interruption(dispatcher_context_t *dc) {
         return -1;
     }
 
-    PRINTF("=> CLA=%02X | INS=%02X | P1=%02X | P2=%02X | Lc=%02X | CData=",
-           cmd.cla,
-           cmd.ins,
-           cmd.p1,
-           cmd.p2,
-           cmd.lc);
-    for (int i = 0; i < cmd.lc; i++) {
-        PRINTF("%02X", cmd.data[i]);
-    }
-    PRINTF("\n");
+    // PRINTF("=> CLA=%02X | INS=%02X | P1=%02X | P2=%02X | Lc=%02X | CData=",
+    //        cmd.cla,
+    //        cmd.ins,
+    //        cmd.p1,
+    //        cmd.p2,
+    //        cmd.lc);
+    // for (int i = 0; i < cmd.lc; i++) {
+    //     PRINTF("%02X", cmd.data[i]);
+    // }
+    // PRINTF("\n");
 
     // INS_CONTINUE is the only valid apdu here
     if (cmd.cla != CLA_FRAMEWORK || cmd.ins != INS_CONTINUE) {

src/common/script.c

@@ -130,6 +130,7 @@ int format_opscript_script(const uint8_t script[],
     }
 
     strncpy(out, "OP_RETURN ", MAX_OPRETURN_OUTPUT_DESC_SIZE);
+    out[MAX_OPRETURN_OUTPUT_DESC_SIZE - 1] = '\0';
     int out_ctr = 10;
 
     // If the length of the script is 1 (just "OP_RETURN"), then it's not standard per bitcoin-core.

src/constants.h

@@ -75,7 +75,8 @@
 #define BBN_LEAF_HASH_STR_LEN   65U
 #define BBN_FINALITY_PK_STR_LEN 65U
 
-#define BBN_COV_PUBKEY_MAX_COUNT 16U
+#define BBN_COV_PUBKEY_MAX_COUNT     16U
+#define BBN_COV_PUBKEY_CURRENT_COUNT 9U
 
 #define BBN_LEAF_HASH_NULL    0U
 #define BBN_LEAF_HASH_DISPALY 1U