Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminal-suggest support for the codium and codium-insiders commands #2233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manuth
Copy link

@manuth manuth commented Feb 22, 2025

Only recently, Visual Studio Code added experimental support for providing suggestions for auto-completing terminal commands for both the code and the code-insiders commands by enabling the terminal.integrated.suggest.enabled option.

Changes made in this PR extend this behavior by adding the very same auto completion capabilities for the codium and the codium-insiders commands, too.

@daiyam
Copy link
Member

daiyam commented Feb 22, 2025

Instead of a patch, in prepare_vscode.sh, I would add:

# terminal-suggest
replace "s|'code'|'codium'|" extensions/terminal-suggest/src/completions/code.ts
replace 's|Visual Studio Code|VSCodium|' extensions/terminal-suggest/src/completions/code.ts
replace 's|code-insiders|codium-insiders|' extensions/terminal-suggest/src/completions/code-insiders.ts
replace 's|Visual Studio Code Insiders|VSCodium Insiders|' extensions/terminal-suggest/src/completions/code-insiders.ts

@manuth
Copy link
Author

manuth commented Feb 23, 2025

Alright then - as recommended, I switched over to using sed instead of Patches.
Tysm for the quick review!

@daiyam
Copy link
Member

daiyam commented Feb 23, 2025

@manuth Why the cp? You can directly modify the existing files.

@manuth
Copy link
Author

manuth commented Feb 23, 2025

@daiyam that's in order to leave the original code and code-insiders autocompletes intact

@daiyam
Copy link
Member

daiyam commented Feb 23, 2025

@daiyam that's in order to leave the original code and code-insiders autocompletes intact

Sorry but for what's purpose?

@manuth
Copy link
Author

manuth commented Feb 23, 2025

tbh, just because it's easily doable
I guess there is also a high likelyhood that people - much like me - have both code or code-insiders and codium or codium-insiders CLIs available on their systems so it's quite handy to have auto-complete for all CLIs in the terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants