Draft
Conversation
…xplicit `abortedByUser` flag and adjusting `stopGenerating` callback.
Author
|
I'd appreciate some feedback on how to handle the UI tool surfacing. Right now, it just shows up as a user message, which might seem somewhat unsettling and lead to a lot of scrolling! |
Owner
|
Hey there, thanks for the PR! Just to let you know, preferably PR's are done to the dev build, as many underlying processes likely have changed. Otherwise, I'll have a proper look at this over the weekend. |
Vali-98
reviewed
Mar 31, 2026
| * Returns extracted text content (if any). | ||
| */ | ||
| processChunk(parsed: any): { text: string | null } { | ||
| const choice = parsed?.choices?.[0] |
Owner
There was a problem hiding this comment.
This extractor should be using the API defined message extractor.
Owner
|
I left a few comments on implementation, also there is the matter of how to represent this in the chat. I believe the idea to have tools as separate messages from the tool caller/response is viable, so its just a matter prettifying the UI for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Folks,
Related to #535
This PR is to pave the way for adding future MCP tools support. Any recommendations on local vs remote MCP support are welcome too!
In short, this PR:
rolefield on chat entriesuseToolsfeature flagWhat's included
ToolCallAccumulator,ToolExecutor,ToolTypes, built-in tool definitionschatInferenceStreamWithToolswith abort supportrole: "tool",tool_calls,tool_call_id)tool_definitionstable,roleonchat_entries,tool_calls/tool_call_idonchat_swipesToolStatezustand store with DB-backed CRUD and built-in tool seedingKnown limitations
Screenshots