Skip to content

Autoload of striped images #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blschatz wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Autoload of striped images #95

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
79d4d3e
Bug: Zip data descriptor was not written on some code paths.
scudette May 25, 2019
9e057c8
Fix bug in map handling
scudette May 31, 2019
987bcf5
Correct and refactor build instructions.
Jun 7, 2019
4c4a4c5
MacOS specific defines and includes.
Jun 7, 2019
b971e29
Bugfix for sizeless ImageStream
Jun 7, 2019
4d37cdf
Add fast Volume URN/ARN identification from Zip file by carving the
Jun 7, 2019
3851234
Add multi-container autoload for striped image support
Jun 7, 2019
10eef8f
Merge remote-tracking branch 'Upstream/master'
Jun 7, 2019
008bf27
Merge remote-tracking branch 'Upstream/data_descriptor'
Jun 7, 2019
6a66a8b
Merge remote-tracking branch 'Upstream/scudette-patch-1'
Jun 7, 2019
1dc699f
Fix MacOS install instructions
Jun 7, 2019
aaeae31
Merge branch 'master' into master
blschatz Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions aff4/aff4_imager_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,7 @@ AFF4Status BasicImager::handle_aff4_volumes() {
AFF4Flusher<AFF4Stream>(backing_stream.release()),
volume));

volume_objs.AddVolume(
std::move(AFF4Flusher<AFF4Volume>(volume.release())));
volume_objs.AddVolume(std::move(AFF4Flusher<AFF4Volume>(volume.release())));
Copy link
Contributor

@jtsylve jtsylve Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the std::move from this call, it's not needed and will stop automatic copy elision

volume_objs.AddSearchPath(volume_to_load);
}
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.