-
Notifications
You must be signed in to change notification settings - Fork 111
Feat/DeltaPrice struct change #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+265
−1,152
Merged
Changes from 11 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
09bade0
BridgePriceInfo/add new props
Velenir 4a7189e
ProtocolName/more protocols
Velenir a9e239a
BridgePrice/add availableBridges
Velenir 7909fce
add no longer used across methods
Velenir 0aa40ea
BuildDeltaOrderDataParams/remove unused beneficiaryType
Velenir 96e7f06
remove extra types
Velenir f0e8c91
tests/simpleSdk/update snapshots
Velenir ed1f4e8
test/nft/update snapshots
Velenir add2e16
tests/quote/fix amounts
Velenir 8d6447e
tests/delta/fix for new price shape
Velenir a1d61c5
tests/quote/relax condition
Velenir 843879f
test/simple & partial/more permissive results check
Velenir 7a83b93
buildDeltaOrder/mark partner & partnerFee as optional
Velenir c6ef5f2
tests/partial/update snapshot
Velenir 65981ab
test/quote/update amounts
Velenir d15bac9
getDeltaOrders/ `chainId` and `status` filters
andriy-shymkiv d3e5555
getDeltaOrders/ get rid of type=ALL
andriy-shymkiv 0d5ee12
update DeltaPirce types
Velenir d188b0a
fix some tests
Velenir 9aaf6d8
fix some tests
Velenir 292fa4e
getDeltaOrders/simplify join
Velenir a17c31a
reexport DeltaOrderFilterByStatus
Velenir 93e63a9
Merge pull request #215 from VeloraDEX/feat/extend_delta_orders_filte…
Velenir e2a5612
fix some tests
Velenir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
AvailableBridgeandAvailableBridgePricetypes lack documentation. Consider adding JSDoc comments to explain their purpose in the context of the new bridge selection system.