user passed port number instead of explicit value#2
Open
paulish wants to merge 3 commits intoVeltroGaming:masterfrom
Open
user passed port number instead of explicit value#2paulish wants to merge 3 commits intoVeltroGaming:masterfrom
paulish wants to merge 3 commits intoVeltroGaming:masterfrom
Conversation
Author
|
Oh, I made a typo in the commit message myself. Read it as "use" not "user" of course. |
- store port as an instance field - add startServer method and make it work with recent node - handle connection errors - add debug argument to constructor to turn off debug logging to console - parse timestamp passed in their numeric representation - pass vote object instead of 4 arguments
pass socket errors to self error handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think 8192 there is just a typo
I would also write it as "this.server.listen(port || 8192);" and removed a line with "port = port || 8192;" before.