Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] package vencord as asar #2707

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

[WIP] package vencord as asar #2707

wants to merge 29 commits into from

Conversation

Vendicated
Copy link
Owner

@Vendicated Vendicated commented Jul 18, 2024

TODO:

  • make git updater work
  • update installer
  • update vesktop
  • test
  • test updater

depeneds on Vencord/Vesktop#771 and new installer release

@thororen1234
Copy link
Contributor

thororen1234 commented Jul 19, 2024

Did some testing and I can confirm the updater does work!

@thororen1234
Copy link
Contributor

thororen1234 commented Jul 19, 2024

Commit 8fa7d00 breaks compiling on windows

Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'

code: 'ERR_UNSUPPORTED_ESM_URL_SCHEME'

@thororen1234
Copy link
Contributor

thororen1234 commented Jul 20, 2024

Commit 8fa7d00 breaks compiling on windows

Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'

code: 'ERR_UNSUPPORTED_ESM_URL_SCHEME'

This might be caused by the actual file extensions using mjs still instead of mts I will test this when I get home.

This did fix it. - Wrong

I forgot I needed to be on node 20 my fault.

@Vendicated Vendicated mentioned this pull request Jul 28, 2024
@Vap0r1ze
Copy link
Contributor

Vap0r1ze commented Aug 1, 2024

mom are we there yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants