Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make noDevtoolsWarning description less ambigous #2881

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

scarf005
Copy link

@scarf005 scarf005 commented Sep 16, 2024

as discussed in discord, current description was ambiguous.

EDIT:

Disables the 'HOLD UP' banner in the console. As a side effect, also prevents Discord from hiding your token, which prevents random logouts.

This can be interpreted in two ways:

  • noDevtoolsWarning prevents discord from hiding your tokens.
  • noDevtoolsWarning prevents random logouts.

OR:

  • noDevtoolsWarning prevents discord from hiding your tokens.
  • Discord hiding your token prevents random logouts.

@RobinRMC
Copy link

This change would make the description worse in my opinion. The current description perfectly states what the plugin does and what you can expect.

I personally find it very annoying that Discord hides my token when I have DevTools open. If the description of this plugin doesn't state that it prevents this feature, I wouldn't have known that this plugin causes my token to stay visible and I wouldn't have known that I should enable this plugin if I want to prevent Discord from hiding my token.

Copy link

@RobinRMC RobinRMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the description with "Disables the 'HOLD UP' banner in the DevTools console. As a side effect, this also prevents Discord from hiding your token and logging you out of your account when you close Discord while DevTools is open."

This describes all of the effects the plugin has on your client and is easy to understand.

@sadan4
Copy link
Contributor

sadan4 commented Sep 17, 2024

tbh just give the plugin a readme.md instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants