Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This suggest what i think can be an API improvement.
VerbalExpression
case class becomes final - a simple "safety" best practice and shows the intention of this not being extended.add
method becomes private. I saw it used only internally, and figured it's not intended to be an API, since it basically kind of exposes implementation detail, and might be dangerous to expose as an API (it receives the string to concatenate).Note that it's still available for tests.
Let me know what you think.