🐛 test(nn): fix test_blocks() with updated functions/classes

[Horgix]

test_blocks() was failing because:

• remove_bn() was renamed by 09640a4 into remove_batchnorm()
• SNResidualDiscrBlock was removed by bcb91b5 - I used ResidualDiscrBlock instead but I'm not sure that's the right thing to do
• Capitalization was wrong on MConvBNReLU - guess it was also changed in a previous commit

This PR makes it pass again 🙂

[Vermeille]

So cool!

You did the right thing renaming SNResidualDiscrBlock to ResidualDiscrBlock since the former is now equivalent to ResidualDiscrBlock().to_spectral_norm()

MConvBNReLU must absolutely get eradicated though. It doesn't do anything wrong really, but doesn't fit in the new design & philosophy or Torchelie. If anything, we should construct the PixelCNN with simple ConvBlocks then use torchelie.nn.utils.edit_model to transform all convs into masked convs.

[Horgix]

You did the right thing renaming SNResidualDiscrBlock to ResidualDiscrBlock since the former is now equivalent to ResidualDiscrBlock().to_spectral_norm()

Cool 🙂

MConvBNReLU must absolutely get eradicated though. It doesn't do anything wrong really, but doesn't fit in the new design & philosophy or Torchelie. If anything, we should construct the PixelCNN with simple ConvBlocks then use torchelie.nn.utils.edit_model to transform all convs into masked convs.

Opened #21 about it!