-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate dreamsim #148
Integrate dreamsim #148
Conversation
…ngsvision tests, and refactcored code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkpoint_path
is currently not passed to the dreamsim
function which has the option cache_dir
. There, the default cache dir is ./models
. I think we should store the checkpoints in the torch default cache dir, as we do for all the ssl models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts @ssundaram21?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree! It's a change we've been planning to make for dreamsim anyways. The checkpoint_path
argument was supposed to be deleted, apologies for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! We should also pass the device
to the dreamsim
function. This is cuda
by default and currently the reason why the tests fail (the ci worker has no GPU).
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 74.28% 74.75% +0.47%
==========================================
Files 27 28 +1
Lines 1287 1319 +32
Branches 185 186 +1
==========================================
+ Hits 956 986 +30
- Misses 277 278 +1
- Partials 54 55 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition!
Integrating
DreamSim
intothingsvision
and minor changes to the codebase (mainly for refactoring purposes)