Update Sync logic #856
Merged
Update Sync logic #856
+69
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the synchronization logic to improve thread safety and initialization handling by replacing manual initialization tracking with a Lazy<Task<>> pattern for loading database table metadata.
Changes:
- Replaced manual initialization tracking (
_tablesWithDatesdictionary and_tablesWithDatesInitializedflag) with aLazy<Task<Dictionary<string, string>>>for thread-safe lazy initialization - Extracted table loading logic into a static method
LoadTablesWithDatesAsyncto support the new lazy initialization pattern - Moved the
_tablesToIgnorearray into the static method to avoid duplication
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PortfolioViewer/PortfolioViewer.ApiService/Services/SyncGrpcService.cs
Outdated
Show resolved
Hide resolved
PortfolioViewer/PortfolioViewer.ApiService/Services/SyncGrpcService.cs
Outdated
Show resolved
Hide resolved
…rvice.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Development container publishedInstall with: |
|
Development container publishedInstall with: |
1 similar comment
Development container publishedInstall with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.