Skip to content

make sure discreteness is set for log2 / log10 scales #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2024
Merged

make sure discreteness is set for log2 / log10 scales #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f3c8f5
make sure discreteness is set for log2 / log10 scales
Vindaar Oct 26, 2024
52ab025
[CI] fix push events to only run when pushing to master branch
Vindaar Oct 26, 2024
1e056cd
update changelog
Vindaar Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:
- 'src/**'
- 'ggplotnim.nimble'
- '.github/workflows/ci.yml'
branches:
- 'master'
pull_request:
paths:
- 'tests/**'
Expand Down
4 changes: 4 additions & 0 deletions changelog.org
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
* v0.7.2
- fix ~scale_x/y_log2/10~ when using it on scales that 'appear' to be
discrete based on their data. It was missing the boolean to indicate
that a fixed discreteness is set
* v0.7.1
- update datamancer dependency for the fix of ~arrange~ in
https://github.com/SciNim/Datamancer/pull/68 for issue
Expand Down
4 changes: 4 additions & 0 deletions src/ggplotnim.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,6 +917,7 @@
scKind: scTransformedData,
axKind: akX,
dcKind: dcContinuous,
hasDiscreteness: true,
trans: trans,
invTrans: invTrans)
result.assignBreaks(breaks)
Expand All @@ -939,6 +940,7 @@
scKind: scTransformedData,
axKind: akY,
dcKind: dcContinuous,
hasDiscreteness: true,
trans: trans,
invTrans: invTrans)
result.assignBreaks(breaks)
Expand All @@ -961,6 +963,7 @@
scKind: scTransformedData,
axKind: akX,
dcKind: dcContinuous,
hasDiscreteness: true,
trans: trans,
invTrans: invTrans)
result.assignBreaks(breaks)
Expand All @@ -983,6 +986,7 @@
scKind: scTransformedData,
axKind: akY,
dcKind: dcContinuous,
hasDiscreteness: true,
trans: trans,
invTrans: invTrans)
result.assignBreaks(breaks)
Expand Down Expand Up @@ -2302,7 +2306,7 @@
result = Theme(yMargin: some(margin.float),
yOutsideRange: orOpt)

proc margin*[T: string | UnitKind](left, right, top, bottom = NaN,

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2309 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]
unit: T = ukCentimeter): Theme =
## Sets the margin around the actual plot. By default the given values are
## interpreted as `cm`. This can be changed using the `unit` argument, either
Expand Down
Loading