Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCST-114: decoupled login error logic between modules #2746

Merged
merged 30 commits into from
Feb 26, 2024
Merged

Conversation

ksavosteev
Copy link
Contributor

@ksavosteev ksavosteev commented Jan 10, 2024

Description

Added token login checks and error descriptions same as in storefront. Need to enable the following setting in platform config to see detailed errors. Otherwise generic LoginFailed error will be shown.

  "PasswordLogin": {
    "DetailedErrors": true
  },

Errors for all users (including admins):

  • If account LockedOut and LockoutEnd == Max Date: UserIsLockedOut
  • If account LockedOut and LockoutEnd != Max Date: UserIsTemporaryLockedOut

Errors only for contacts:

First need to pass storeId param to token/connect endpoint:

grant_type=password&scope=offline_access&username=<...>&password=<...>&storeId=B2B-store
  • If no StoreId passed or StoreId != user store: UserCannotLoginInStore
  • If account LockedOut and Contact status == "Locked" and user Email not confirmed and Email confirmation required: EmailVerificationIsRequired

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-114

Artifact URL:

Tagged version is: 3.809.0-alpha.12891-vcst-114-f2b03433

Copy link

sonarqubecloud bot commented Feb 26, 2024

@ksavosteev ksavosteev merged commit 06cf1fb into dev Feb 26, 2024
7 checks passed
@ksavosteev ksavosteev deleted the feat/VCST-114 branch February 26, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants