-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCST-114: decoupled login error logic between modules #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegoO
approved these changes
Jan 16, 2024
OlegoO
approved these changes
Feb 1, 2024
OlegoO
approved these changes
Feb 1, 2024
artem-dudarev
requested changes
Feb 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added token login checks and error descriptions same as in storefront. Need to enable the following setting in platform config to see detailed errors. Otherwise generic LoginFailed error will be shown.
Errors for all users (including admins):
Errors only for contacts:
First need to pass storeId param to token/connect endpoint:
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-114
Artifact URL:
Tagged version is: 3.809.0-alpha.12891-vcst-114-f2b03433