Misc no-op and/or error handling for the --test command line flag
#3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
changed the title
--test is passed
Gedochao
changed the title
--test is passedexport with a meaningful message if --test is passed
Gedochao
force-pushed
the
feature/noop-test-flag
branch
2 times, most recently
from
456fb37 to
4475674
Compare
Gedochao
changed the title
export with a meaningful message if --test is passed--test command line flag
Gedochao
force-pushed
the
feature/noop-test-flag
branch
from
4475674 to
e67f61f
Compare
Gedochao
force-pushed
the
feature/noop-test-flag
branch
from
e67f61f to
3aa4b87
Compare
tgodzik
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on Support the--testflag with thepublish&publish localsub-commands #3538This adds support for the
--testflag to a bunch of sub-commands, which wouldn't benefit from it at this point in time, but we want to still handle it there before we make the flag a part ofSharedOptions(which in turn, will be necessary to properly support it in IDEs).This means
exportsub-command will fail when--testis passed with a meaningful message.--testwould merge the test scope to the main, and be exported as such. we won't support that for now (and I dunno if ever, depends on demand I guess)dependency updateandfmtwill just ignore the option, but raise a warning that it doesn't change anything.