Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scala-cli version to the BuildInfo #3617

Merged
merged 12 commits into from
Apr 10, 2025

Conversation

yadavan88
Copy link
Contributor

@yadavan88 yadavan88 commented Apr 4, 2025

Add a variable for the scalaCliVersion in the generated BuildInfo

@yadavan88
Copy link
Contributor Author

@Gedochao Here is the PR for adding scala-cli version to buildInfo. Could you please review?

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on some nitpicks.
Also, please include a test.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Gedochao Gedochao merged commit 224f094 into VirtusLab:main Apr 10, 2025
54 checks passed
@yadavan88 yadavan88 deleted the buildinfo-scala-cli-version branch April 10, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants