-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scala-cli version to the BuildInfo #3617
Add scala-cli version to the BuildInfo #3617
Conversation
@Gedochao Here is the PR for adding scala-cli version to buildInfo. Could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented on some nitpicks.
Also, please include a test.
modules/options/src/main/scala/scala/build/info/BuildInfo.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr Chabelski <[email protected]>
…van88/scala-cli into buildinfo-scala-cli-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
Add a variable for the scalaCliVersion in the generated BuildInfo