Allow version 1.3.1 to work in strict mode #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. I think I gonna merge this PR and release the update for 1.3. Thanks for the fixes. |
|
Hi :) any movement on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys - I work with @far-blue at Namesco. We are currently using the old-ish 1.3.1 version of NestedTypes and recently needed to get said version to run in strict mode. So, here's a PR that covers the changes to do that. Note that tests that previously passed still pass (no new fails).
Whether you want to do anything with this PR I'm not sure, given the age of the codebase 😄