Skip to content

PE-7250: Fix search VS bug #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyangsun merged 1 commit into from
Aug 14, 2025
Merged

PE-7250: Fix search VS bug #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions internal/rag/openai_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,15 +279,9 @@ func (o *OpenAIProvider) ListFiles(ctx context.Context, limit int) ([]FileInfo,
func (o *OpenAIProvider) Search(ctx context.Context, query string, options SearchOptions) ([]SearchResult, error) {
fmt.Printf("[RAG] OpenAI: Vector Store search for query '%s' (vector_store: %s)\n", query, o.vectorStoreID)

// Check if vector store ID is empty
if o.vectorStoreID == "" {
// Use dynamic vector store
fmt.Printf("[RAG] OpenAI: Using dynamic vector store\n")
vectorStoreID, err := o.searchVectorStore(ctx, o.config.VectorStoreNameRegex)
if err != nil {
return nil, fmt.Errorf("failed to search vector store: %w", err)
}
o.vectorStoreID = vectorStoreID
vectorStoreID, err := o.searchVectorStore(ctx, o.config.VectorStoreNameRegex)
if err != nil {
return nil, fmt.Errorf("failed to search vector store: %w", err)
}

// Set up search parameters
Expand All @@ -314,7 +308,7 @@ func (o *OpenAIProvider) Search(ctx context.Context, query string, options Searc
},
}

searchResults, err := o.client.VectorStores.Search(ctx, o.vectorStoreID, searchParams)
searchResults, err := o.client.VectorStores.Search(ctx, vectorStoreID, searchParams)
if err != nil {
return nil, fmt.Errorf("vector store search failed: %w", err)
}
Expand Down Expand Up @@ -428,6 +422,10 @@ func (o *OpenAIProvider) findVectorStoreByName(ctx context.Context, name string)
}

func (o *OpenAIProvider) searchVectorStore(ctx context.Context, vectorStoreNameRegex string) (string, error) {
if o.vectorStoreID != "" {
return o.vectorStoreID, nil
}

if vectorStoreNameRegex == "" {
return "", fmt.Errorf("vector store name regex cannot be empty")
}
Expand Down
Loading