Fix carla_localization: correct base_frame docs and add missing nav_msgs dependency#414
Draft
hassaan141 with Copilot wants to merge 2 commits into
Draft
Fix carla_localization: correct base_frame docs and add missing nav_msgs dependency#414hassaan141 with Copilot wants to merge 2 commits into
hassaan141 with Copilot wants to merge 2 commits into
Conversation
…dency Agent-Logs-Url: https://github.com/WATonomous/wato_monorepo/sessions/41c7acad-64bf-483e-a895-bfe6283a569b Co-authored-by: hassaan141 <139821283+hassaan141@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Carla Sim for improved performance
Fix carla_localization: correct base_frame docs and add missing nav_msgs dependency
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
carla_localizationpackage had documentation referring tobase_linkwhile the actual code, config, and tests all usebase_footprint. Additionally,nav_msgswas missing frompackage.xmldespitelocalization_node.pyimporting and publishingnav_msgs/Odometry.Changes
README.md/DEVELOPING.md: Replace all references tobase_linkwithbase_footprintto match the actual default parameter value and TF tree (map → odom → base_footprint)package.xml: Add<depend>nav_msgs</depend>— required by theOdometrypublisher inlocalization_node.py