Conversation
tunetheweb
approved these changes
Mar 24, 2026
Collaborator
tunetheweb
left a comment
tunetheweb
left a comment
There was a problem hiding this comment.
Overall LGTM but one nit and a question.
| await new Promise((resolve) => setTimeout(resolve, 1000)); | ||
| await writer.write( | ||
| `<template for=data><?start>${i}</template>`, | ||
| `<template for=data><?start name="data">${i}</template>`, |
Collaborator
There was a problem hiding this comment.
Just to be clear here, the intent of this one is to overwrite the contents each time?
So it's 1, then 2, then 3... etc.
And not 1234567...
?
Co-authored-by: Barry Pollard <barrypollard@google.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 24, 2026
SHA: cef7cdc Reason: push, by noamr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.