Skip to content

refactor(CRaterRequest): Create AbstractCRaterRequest #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 2 commits into from
Feb 19, 2025
Merged

refactor(CRaterRequest): Create AbstractCRaterRequest #289

hirokiterashima merged 2 commits into from
Feb 19, 2025

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Feb 12, 2025 •
edited
Loading

Changes

  • Moved duplicate code from CRaterScoringRequest and CRaterVerificationRequest into new AbstractCRaterRequest.

Test

  • Make sure that CRater scoring requests (dialog guidance) and CRater verification requests (open response, enable CRater) still work.

Closes #285

@Aaron-Detre Aaron-Detre changed the base branch from develop to issue-286-allow-requests-to-berkeley-endpoint February 12, 2025 22:07
@Aaron-Detre Aaron-Detre self-assigned this Feb 13, 2025
@Aaron-Detre Aaron-Detre added the enhancement New feature or request label Feb 13, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review February 13, 2025 08:21
hirokiterashima
hirokiterashima requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification doesn't work anymore.

Looks like we need this line?

    body.put("service", "VerificationService");

hirokiterashima
hirokiterashima approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima hirokiterashima merged commit fae188b into issue-286-allow-requests-to-berkeley-endpoint Feb 19, 2025
2 checks passed
@hirokiterashima hirokiterashima deleted the issue-285-create-AbstractCRaterRequest branch February 19, 2025 00:15
@hirokiterashima hirokiterashima mentioned this pull request Mar 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@Aaron-Detre Aaron-Detre

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aaron-Detre @hirokiterashima