Skip to content

Conversation

@hirokiterashima
Copy link
Member

Changes

  • Convert ChooseNewComponent to standalone component
  • Clean up code

Test

  • In the add new component dialog in the AT
    • the component options appear and work as before
    • "cancel" button works as before
    • "import" button works as before

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Jul 16, 2024
@hirokiterashima hirokiterashima self-assigned this Jul 16, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review July 16, 2024 17:50
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The add component view works but the create new step view no longer shows the component type buttons.

@hirokiterashima
Copy link
Member Author

Good catch. Fixed. PTAL.

Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 8208a98 into develop Jul 30, 2024
@hirokiterashima hirokiterashima deleted the convert-ChooseNewComponent-to-standalone branch July 30, 2024 17:55
@geoffreykwan
Copy link
Member

🎉 This PR is included in version 5.154.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants