Skip to content

refactor(ComponentNewWorkBadgeComponent): Convert to standalone #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 2 commits into from
Jul 30, 2024
Merged

refactor(ComponentNewWorkBadgeComponent): Convert to standalone #1874

hirokiterashima merged 2 commits into from
Jul 30, 2024

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Jul 30, 2024

Changes

  • Convert ComponentNewWorkBadgeComponent to standalone component
  • Clean up code

Test

  • In CM > grade by team > step item
    • The "New" badge appears next to the step title if you have never scored/commented on it, or the work is newer than the last scored/commented time

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Jul 30, 2024
@hirokiterashima hirokiterashima self-assigned this Jul 30, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review July 30, 2024 00:22
geoffreykwan
geoffreykwan approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit a708481 into develop Jul 30, 2024
@hirokiterashima hirokiterashima deleted the convert-ComponentNewWorkBadge-to-standalone branch July 30, 2024 18:27
@geoffreykwan
Copy link
Member

geoffreykwan commented Jul 30, 2024

🎉 This PR is included in version 5.154.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality released

Projects

No open projects
WISE Development 2023-2024
Status: Done

Milestone

Tech Debt 18 -> 17

Development

Successfully merging this pull request may close these issues.

3 participants

@hirokiterashima @geoffreykwan