Skip to content

refactor(TeacherProjectService): Extract NotifyAuthorService #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 2 commits into from
Aug 14, 2024
Merged

refactor(TeacherProjectService): Extract NotifyAuthorService #1884

hirokiterashima merged 2 commits into from
Aug 14, 2024

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 13, 2024

Changes

  • Extract code to notify concurrent authors for a unit to NotifyAuthorService

Test

  • Concurrent authors message ("Also currently editing this unit...") appears at the top of the AT as before when two authors are editing the same unit. The message should disappear when one is no longer authoring the unit (closes the AT or signs out)

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 13, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 13, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 13, 2024 00:31
geoffreykwan
geoffreykwan approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 3c05ed8 into develop Aug 14, 2024
@hirokiterashima hirokiterashima deleted the refactor-teacherProjectService-extract-notifyAuthorService branch August 14, 2024 16:00
@geoffreykwan
Copy link
Member

geoffreykwan commented Aug 22, 2024

🎉 This issue has been resolved in version 5.156.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality released

Projects

No open projects
WISE Development 2023-2024
Status: Done

Milestone

Tech Debt 18 -> 17

Development

Successfully merging this pull request may close these issues.

3 participants

@hirokiterashima @geoffreykwan