Skip to content

refactor(NotebookItemComponent): Convert to standalone #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 1 commit into from
Aug 14, 2024
Merged

refactor(NotebookItemComponent): Convert to standalone #1890

hirokiterashima merged 1 commit into from
Aug 14, 2024
+110 −152

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 14, 2024

Changes

  • Convert NotebookItemComponent to standalone component
  • Clean up code

Test

  • For a unit with student notebook enabled, open the Notebook notes side panel in the student VLE and add some notes.
    • the notes should appear in the side panel
    • you can edit the note text, and it should update in the side panel listing
    • you can delete the note, and it should disappear from the side panel listing

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 14, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 14, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 14, 2024 16:00
@hirokiterashima hirokiterashima requested a review from breity August 14, 2024 16:00
breity
breity approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 6ac274e into develop Aug 14, 2024
@hirokiterashima hirokiterashima deleted the convert-notebookItemComponent-to-standalone branch August 14, 2024 18:54
@geoffreykwan
Copy link
Member

geoffreykwan commented Aug 22, 2024

🎉 This issue has been resolved in version 5.156.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality released

Projects

No open projects
WISE Development 2023-2024
Status: Done

Milestone

Tech Debt 18 -> 17

Development

Successfully merging this pull request may close these issues.

4 participants

@hirokiterashima @geoffreykwan @breity