Skip to content

refactor(TeacherProjectService): Move constraint-related functions to ConstraintService #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 1 commit into from
Aug 15, 2024
Merged

refactor(TeacherProjectService): Move constraint-related functions to ConstraintService #1892

hirokiterashima merged 1 commit into from
Aug 15, 2024

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 15, 2024

Changes

  • Move constraint-related functions getConstraintDescriptions() and getCriteriaMessage() to ConstraintService and update references
  • Remove first null-check in getCriteriaMessage(). This function should take in a non-null criteria

Test

  • In AT unit view, if a node has any constraint, the constraint icon should appear next to the node title. Hovering over it should display the message describing the constraint
  • In Student VLE, if a node has a constraint (for example, "must complete step before moving on" constraint), it should display the dialog with the constraint description when you try to move on before completing the step.

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 15, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 15, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 15, 2024 00:39
geoffreykwan
geoffreykwan approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 6c6dc16 into develop Aug 15, 2024
@hirokiterashima hirokiterashima deleted the refactor-teacherProjectService-move-constraint-functions branch August 15, 2024 21:59
@geoffreykwan
Copy link
Member

geoffreykwan commented Aug 22, 2024

🎉 This issue has been resolved in version 5.156.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality released

Projects

No open projects
WISE Development 2023-2024
Status: Done

Milestone

Tech Debt 18 -> 17

Development

Successfully merging this pull request may close these issues.

3 participants

@hirokiterashima @geoffreykwan