Skip to content

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 16, 2024

Changes

  • Move deleteTransition() from TeacherProjectService to Node and update references

Test

  • In node advanced authoring > edit transitions, try deleting path(s) and verify that the changes are properly reflected in the node's JSON. (transitionLogic.transitions array)

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 16, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 16, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 16, 2024 01:38
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit bbf6256 into develop Aug 19, 2024
@hirokiterashima hirokiterashima deleted the refactor-teacherProjctService-move-deleteTransition-to-node branch August 19, 2024 15:06
@geoffreykwan
Copy link
Member

🎉 This issue has been resolved in version 5.156.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants