Skip to content

refactor(TeacherProjectService): Move setMaxScoreForComponent to GradingEditComponentMaxScore #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hirokiterashima wants to merge 2 commits into from
Closed

refactor(TeacherProjectService): Move setMaxScoreForComponent to GradingEditComponentMaxScore #1897

hirokiterashima wants to merge 2 commits into from

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 16, 2024

Changes

  • Remove TeacherProjectService.setMaxScoreForComponent() and implement it in GradingEditComponentMaxScoreComponent. No need to null-check the component, because we are editing the max score for a specific component at this stage.

Test

  • In CM > grade by team or step, set the max score for a component. It should save.

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 16, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 16, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 16, 2024 03:50
@hirokiterashima hirokiterashima requested a review from breity August 16, 2024 03:50
@hirokiterashima
Copy link
Member Author

hirokiterashima commented Aug 20, 2024

Duplicate of #1893

@hirokiterashima hirokiterashima marked this as a duplicate of #1893 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breity breity Awaiting requested review from breity

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality

Projects

No open projects
WISE Development 2023-2024
Status: Done

Milestone

Tech Debt 18 -> 17

Development

Successfully merging this pull request may close these issues.

2 participants

@hirokiterashima