Skip to content

refactor(TeacherProjectService): Move functions to MoveNodeService #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 1 commit into from
Aug 20, 2024
Merged

refactor(TeacherProjectService): Move functions to MoveNodeService #1902

hirokiterashima merged 1 commit into from
Aug 20, 2024

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 20, 2024

Changes

  • Move functions related to moving nodes from TeacherProjectService to MoveNodeService, where it's being used
    • moveToActive()
    • moveToInactive()
    • removeNodeFromActiveNodes()
    • removeChildNodesFromActiveNodes()
    • moveFromActiveToInactiveInsertInside()
    • moveFromInactiveToInactiveInsertInside()
  • Add private modifiers and return types

Test

  • In AT > unit view, move nodes and make sure they work as before, for node(s) and group(s) in these directions:
    - active -> active
    - active -> inactive
    - inactive -> active
    - inactive -> inactive

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 20, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 20, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 20, 2024 03:34
geoffreykwan
geoffreykwan approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 1465073 into develop Aug 20, 2024
@hirokiterashima hirokiterashima deleted the refactor-teacherProjectService-move-functions-to-moveNodeService branch August 20, 2024 20:29
@geoffreykwan
Copy link
Member

geoffreykwan commented Aug 22, 2024

🎉 This issue has been resolved in version 5.156.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality released

Projects

No open projects
WISE Development 2023-2024
Status: Done

Milestone

Tech Debt 18 -> 17

Development

Successfully merging this pull request may close these issues.

3 participants

@hirokiterashima @geoffreykwan