Skip to content

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 20, 2024

Changes

  • Convert NodeNavigationComponent to standalone component. This component is used to show/hide the prev/next buttons at the bottom of the page for a tabbed navigation themed unit.
  • Clean up code

Test Prep

Make a unit use the tabbed navigation theme. In AT > Project JSON view, add this as the top JSON attribute:

    "theme": "tab",

Test

  • In VLE for a unit tab theme (see "Test Prep" above)
    • the prev button is hidden when there is no previous step (e.g., you're on the first step in the unit)
    • the next button is hidden when there is no next step (e.g., you're on the last step in the unit)
    • the prev and next buttons should be visible in other cases

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 20, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 20, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 20, 2024 15:50
@hirokiterashima hirokiterashima requested a review from breity August 20, 2024 15:50
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See inline feedback about comments in the test file.

@hirokiterashima hirokiterashima merged commit 6d8823b into develop Aug 21, 2024
@hirokiterashima hirokiterashima deleted the convert-nodeNavigation-to-standalone branch August 21, 2024 18:33
@geoffreykwan
Copy link
Member

🎉 This issue has been resolved in version 5.156.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants