Skip to content

refactor(TeacherProjectService): Move branch description functions to ProjectAuthoringStepComponent #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 2 commits into from
Aug 22, 2024
Merged

refactor(TeacherProjectService): Move branch description functions to ProjectAuthoringStepComponent #1906

hirokiterashima merged 2 commits into from
Aug 22, 2024

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 20, 2024 •
edited
Loading

Changes

  • Move functions related to generating branch description text from TeacherProjectService to ProjectAuthoringStepComponent, where it's actually being used
    • getNumberOfBranchPaths()
    • getBranchCriteriaDescription()
  • Clean up code

Test

  • In AT > unit view for a unit with branches, the tooltip text on the branch icon should display text with how many paths the branch has and what the branch criteria is, like this:
Screenshot 2024-08-20 at 1 59 21 PM Screenshot 2024-08-20 at 2 01 34 PM

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 20, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 20, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 20, 2024 21:08
@hirokiterashima hirokiterashima requested a review from breity August 20, 2024 21:10
breity
breity approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hirokiterashima hirokiterashima merged commit 0b7b271 into develop Aug 22, 2024
@hirokiterashima hirokiterashima deleted the refactor-teacherProjectService-move-branch-description-functions-to-projectAuthoringStepComponent branch August 22, 2024 23:09
@hirokiterashima
Copy link
Member Author

hirokiterashima commented Sep 10, 2024

🎉 This issue has been resolved in version 5.156.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality released

Projects

No open projects
WISE Development 2023-2024
Status: Done

Milestone

Tech Debt 18 -> 17

Development

Successfully merging this pull request may close these issues.

3 participants

@hirokiterashima @breity