refactor(TeacherDataService): Extract runStatus-related functions to RunStatusService #1907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirokiterashima
approved these changes
Aug 21, 2024
Member
hirokiterashima
left a comment
hirokiterashima
left a comment
There was a problem hiding this comment.
LGTM. I added minor code improvement suggestions inline.
Comment on lines
20
to
26
| subscribeToEvents(): void { | ||
| this.configService.configRetrieved$.subscribe(() => { | ||
| if (this.configService.isClassroomMonitor()) { | ||
| this.retrieveRunStatus(); | ||
| } | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
Move inside body of constructor and remove function?
| }); | ||
| } | ||
|
|
||
| retrieveRunStatus(): Observable<any> { |
Member
There was a problem hiding this comment.
Type RunStatus?
Suggested change
| retrieveRunStatus(): Observable<any> { | |
| retrieveRunStatus(): Observable<RunStatus> { |
|
|
||
| setRunStatus(runStatus: RunStatus): void { | ||
| this.runStatus = runStatus; | ||
| setPeriods(periods: any[]) { |
Member
There was a problem hiding this comment.
Suggested change
| setPeriods(periods: any[]) { | |
| setPeriods(periods: any[]): void { |
| import { TeacherWebSocketService } from '../../assets/wise5/services/teacherWebSocketService'; | ||
| import { NotebookService } from '../../assets/wise5/services/notebookService'; | ||
| import { AchievementService } from '../../assets/wise5/services/achievementService'; | ||
| import { RunStatus } from '../../assets/wise5/common/RunStatus'; |
Member
|
🎉 This issue has been resolved in version 5.156.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test