Skip to content

refactor(GroupTabsComponent): Convert to standalone #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 1 commit into from
Aug 23, 2024
Merged

refactor(GroupTabsComponent): Convert to standalone #1913

hirokiterashima merged 1 commit into from
Aug 23, 2024

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 21, 2024

Changes

  • Convert GroupTabsComponent to standalone
  • Clean up code
  • Update tests to use harness instead of making the component's functions public (just for the sake of testing)

Test Prep

Make a unit use the tabbed navigation theme. In AT > Project JSON view, add this as the top JSON attribute:

    "theme": "tab",

Test (in VLE)

  • For a unit with tab theme (see "Test Prep" above), the lessons appears as tabs, and you can click on the tab to go to the lesson
  • For a unit with regular (non-tab) theme, the VLE loads and works as before

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 21, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 21, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 21, 2024 19:34
@hirokiterashima hirokiterashima requested a review from breity August 21, 2024 19:34
breity
breity approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hirokiterashima hirokiterashima merged commit e7ba216 into develop Aug 23, 2024
@hirokiterashima hirokiterashima deleted the convert-groupTabsComponent-to-standalone branch August 23, 2024 18:32
@hirokiterashima
Copy link
Member Author

hirokiterashima commented Sep 10, 2024

🎉 This issue has been resolved in version 5.156.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality released

Projects

No open projects
WISE Development 2023-2024
Status: Done

Milestone

Tech Debt 18 -> 17

Development

Successfully merging this pull request may close these issues.

3 participants

@hirokiterashima @breity