Skip to content

Conversation

@Aaron-Detre
Copy link
Contributor

Changes

  • Added functionality for authors to specify student-friendly descriptions for cRater ideas.

Test

  • Add new idea description boxes with either of the buttons.
  • The button at the bottom is only visible when 1 or more idea description boxes are present.
  • Adding a new idea description box adds an entry to cRaterRubric.ideas in the component JSON file.
  • Edits made in the "Idea #" or "Student-Friendly Description" text boxes are stored in the corresponding idea in the JSON file.
  • When an idea description box is deleted, the corresponding idea should be removed from the JSON file.
  • When adding an idea description box, the window should auto-scroll down to the bottom.

Closes #2055

@Aaron-Detre Aaron-Detre self-assigned this Jan 31, 2025
@Aaron-Detre Aaron-Detre added the enhancement New feature of any size or improvement (UI, performance, security) label Jan 31, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review January 31, 2025 05:49
@Aaron-Detre Aaron-Detre changed the title Issue 2055 allow authors specify text for ideas feat(DialogGuidance): Allow authors specify text for ideas Jan 31, 2025
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Functionality seems to work as described.

I expected that clicking the add button at the top would add new idea descriptions at the top of the list instead of the bottom.

We don't currently allow reordering items. Maybe that's okay for now.

I also added some code improvement suggestions inline. If it looks good, go ahead and make the change and re-commit. We can also discuss any suggestion if you'd like.

@breity can you take a look at styling a bit? The delete button alignment looks a bit off

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can merge after Jon styles this component. We'll also need to modify this later when we rename the fields.

We may even not need the getNumIdeaDescriptions() function, since this.ideaDescriptions is a public field of the component? We can just call this.ideaDescriptions.length in the component and ideaDescriptions.length in the template.

@breity breity merged commit e99910b into develop Feb 7, 2025
5 checks passed
@breity breity deleted the issue-2055-allow-authors-specify-text-for-ideas branch February 7, 2025 06:23
@hirokiterashima
Copy link
Member

🎉 This issue has been resolved in version 5.171.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(DialogGuidance): Allow authors to specify student-friendly text for ideas

4 participants