-
Notifications
You must be signed in to change notification settings - Fork 5
feat(DialogGuidance): Allow authors specify text for ideas #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DialogGuidance): Allow authors specify text for ideas #2076
Conversation
…descriptions of ideas (first draft)
…separate component
hirokiterashima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. Functionality seems to work as described.
I expected that clicking the add button at the top would add new idea descriptions at the top of the list instead of the bottom.
We don't currently allow reordering items. Maybe that's okay for now.
I also added some code improvement suggestions inline. If it looks good, go ahead and make the change and re-commit. We can also discuss any suggestion if you'd like.
@breity can you take a look at styling a bit? The delete button alignment looks a bit off
...nts/common/cRater/edit-crater-idea-descriptions/edit-crater-idea-descriptions.component.html
Outdated
Show resolved
Hide resolved
...nts/common/cRater/edit-crater-idea-descriptions/edit-crater-idea-descriptions.component.html
Outdated
Show resolved
Hide resolved
...nts/common/cRater/edit-crater-idea-descriptions/edit-crater-idea-descriptions.component.html
Outdated
Show resolved
Hide resolved
...nents/common/cRater/edit-crater-idea-descriptions/edit-crater-idea-descriptions.component.ts
Outdated
Show resolved
Hide resolved
...nents/common/cRater/edit-crater-idea-descriptions/edit-crater-idea-descriptions.component.ts
Outdated
Show resolved
Hide resolved
...nents/common/cRater/edit-crater-idea-descriptions/edit-crater-idea-descriptions.component.ts
Outdated
Show resolved
Hide resolved
...nents/common/cRater/edit-crater-idea-descriptions/edit-crater-idea-descriptions.component.ts
Outdated
Show resolved
Hide resolved
hirokiterashima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can merge after Jon styles this component. We'll also need to modify this later when we rename the fields.
We may even not need the getNumIdeaDescriptions() function, since this.ideaDescriptions is a public field of the component? We can just call this.ideaDescriptions.length in the component and ideaDescriptions.length in the template.
…tent on authoring load
|
🎉 This issue has been resolved in version 5.171.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes
Test
Closes #2055