Skip to content

refactor(MatchStudentDefault): Convert to standalone #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 8 commits into from
Feb 11, 2025
Merged

refactor(MatchStudentDefault): Convert to standalone #2082

hirokiterashima merged 8 commits into from
Feb 11, 2025

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Feb 4, 2025 •
edited
Loading

Changes

  • Converted MatchStudentDefault to standalone.
  • Refactored some methods to try to reduce method complexity.

Test

  • Buckets and items look normal.
  • Items can be moved between buckets and reordered within the same bucket.
  • Students can add their own items and then can remove those items.
  • Submit button grades items correct or incorrect.

Closes #2074

@Aaron-Detre Aaron-Detre changed the title Issue 2074 match student default standalone refactor(MatchStudentDefault): Convert to standalone Feb 4, 2025
@Aaron-Detre Aaron-Detre self-assigned this Feb 6, 2025
@Aaron-Detre Aaron-Detre added this to the Standalone Components milestone Feb 6, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review February 6, 2025 21:20
@hirokiterashima hirokiterashima merged commit 7c13610 into develop Feb 11, 2025
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the issue-2074-MatchStudentDefault-Standalone branch February 11, 2025 21:45
@hirokiterashima
Copy link
Member

hirokiterashima commented Mar 26, 2025

🎉 This PR is included in version 5.172.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima Awaiting requested review from hirokiterashima

Assignees

@Aaron-Detre Aaron-Detre

Labels

Code Quality released

Projects

None yet

Milestone

Standalone Components

Development

Successfully merging this pull request may close these issues.

refactor(MatchStudentDefault): Convert to standalone

3 participants

@Aaron-Detre @hirokiterashima