Skip to content

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Feb 6, 2025

Changes

  • Upgrade to Angular 19
  • Upgrade dependencies
    • wise-draw: was using fabric (depended on jsdom, which was causing building issues), changed to fabric-browser
    • fabric (depended on jsdom, which was causing building issues): changed to fabric-browser
    • password-strength-meter: was not compatible with Angular 19
  • Remove dom-autoscroller library since it wasn't doing anything
  • Components are standalone by default. This is why there are many changed components

Test

  • Everything works as before

~ Conflicts:
~	src/assets/wise5/classroomMonitor/classroomMonitorComponents/manageStudents/show-student-info/show-student-info.component.ts
@hirokiterashima hirokiterashima marked this pull request as ready for review February 11, 2025 02:09
@hirokiterashima
Copy link
Member Author

@breity starting the dev-server shows a lot of angular-sass deprecation warnings. Can you try addressing them? It looks like it's 2 or 3 issues that occur in many files, so addressing one should remove many warnings.

Also, can you address the minor styling issues that we discussed last week (border around topbar, notebook color, etc)?

Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I fixed the styling we discussed and fixed the Back to Top button so that it appears again when scrolling up. I'm leaving the SASS deprecation warnings for now. These will be addressed when we update the Angular Material themes to v19 syntax.

@breity breity requested a review from Aaron-Detre February 12, 2025 19:20
Copy link
Contributor

@Aaron-Detre Aaron-Detre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some potential issues while testing it out, but all of those issues are also present on the current Angular 18 version of the site. So those might be things to look at some other time, but as for this upgrade, everything looked good.

@hirokiterashima
Copy link
Member Author

@Aaron-Detre Great. Thanks for testing. Let's discuss the issue you found.

@hirokiterashima hirokiterashima merged commit f1660a9 into develop Feb 25, 2025
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the angular-19 branch February 25, 2025 20:09
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.172.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants