-
Notifications
You must be signed in to change notification settings - Fork 5
chore(Application): Upgrade to Angular 19 #2087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
~ Conflicts: ~ src/assets/wise5/classroomMonitor/classroomMonitorComponents/manageStudents/show-student-info/show-student-info.component.ts
|
@breity starting the dev-server shows a lot of angular-sass deprecation warnings. Can you try addressing them? It looks like it's 2 or 3 issues that occur in many files, so addressing one should remove many warnings. Also, can you address the minor styling issues that we discussed last week (border around topbar, notebook color, etc)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
I fixed the styling we discussed and fixed the Back to Top button so that it appears again when scrolling up. I'm leaving the SASS deprecation warnings for now. These will be addressed when we update the Angular Material themes to v19 syntax.
Aaron-Detre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some potential issues while testing it out, but all of those issues are also present on the current Angular 18 version of the site. So those might be things to look at some other time, but as for this upgrade, everything looked good.
|
@Aaron-Detre Great. Thanks for testing. Let's discuss the issue you found. |
|
🎉 This PR is included in version 5.172.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes
Test