Skip to content

refactor(Unit Library): Share FilterValues in LibraryService #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 4 commits into from
Apr 29, 2025
Merged

refactor(Unit Library): Share FilterValues in LibraryService #2161

hirokiterashima merged 4 commits into from
Apr 29, 2025

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Apr 28, 2025 •
edited
Loading

Changes

  • Use the ProjectFilterValues object in the LibraryService across all components. Each component has access to the one same object. Emit an event when any component updates the object. This tells the library to run the matches() function

Test

  • Unit Library works as before, in the homepage, curriculum, and teacher home

@hirokiterashima hirokiterashima added this to the Tech Debt 16 -> 15 milestone Apr 28, 2025
@hirokiterashima hirokiterashima self-assigned this Apr 28, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review April 29, 2025 00:51
@hirokiterashima hirokiterashima changed the title refactor(Unit Library): Pass in FilterValues to simplify code refactor(Unit Library): Share FilterValues in LibraryService Apr 29, 2025
@hirokiterashima hirokiterashima merged commit f3cbd21 into develop Apr 29, 2025
6 checks passed
@hirokiterashima hirokiterashima deleted the refactor-unit-library-pass-in-filter-values branch April 29, 2025 01:36
@hirokiterashima
Copy link
Member Author

hirokiterashima commented May 1, 2025

🎉 This PR is included in version 5.179.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality released

Projects

None yet

Milestone

Tech Debt 16 -> 15

Development

Successfully merging this pull request may close these issues.

2 participants

@hirokiterashima