refactor(VLE): Convert all components to standalone #2241

hirokiterashima · 2025-10-15T16:58:58Z

Changes

Converts all components in the VLE, AT, and Teacher Tools to standalone
Clean up related files, remove unnecessary modules

Test

VLE, AT, and Teacher Tools work as before

…d files

…lean up related files

…lated files

…so it is opened by messages, instead of function call in ComponentStudentComponent because this was causing circular dependency

qltysh · 2025-10-15T17:00:09Z

❌ 23 blocking issues (23 total)

Tool	Category	Rule	Count
qlty	Structure	Function with many parameters (count = 9): constructor	11	❌
qlty	Duplication	Found 15 lines of similar code in 2 locations (mass = 66)	11	❌
qlty	Duplication	Found 22 lines of identical code in 2 locations (mass = 78)	1	❌

qltysh · 2025-10-15T17:00:12Z

src/assets/wise5/components/animation/animation-student/animation-student.component.ts

  constructor(
-    private AnimationService: AnimationService,
-    protected AnnotationService: AnnotationService,
-    protected ComponentService: ComponentService,
-    protected ConfigService: ConfigService,
+    private animationService: AnimationService,
+    protected annotationService: AnnotationService,
+    protected componentService: ComponentService,
+    protected configService: ConfigService,
    protected dialog: MatDialog,
-    protected NodeService: NodeService,
-    protected NotebookService: NotebookService,
-    protected StudentAssetService: StudentAssetService,
-    protected StudentDataService: StudentDataService
+    protected nodeService: NodeService,
+    protected notebookService: NotebookService,
+    protected studentAssetService: StudentAssetService,
+    protected studentDataService: StudentDataService


Function with many parameters (count = 9): constructor [qlty:function-parameters]

qltysh · 2025-10-15T17:00:13Z

...e5/components/audioOscillator/audio-oscillator-student/audio-oscillator-student.component.ts

  constructor(
-    protected AnnotationService: AnnotationService,
-    private AudioOscillatorService: AudioOscillatorService,
-    protected ComponentService: ComponentService,
-    protected ConfigService: ConfigService,
+    protected annotationService: AnnotationService,
+    private audioOscillatorService: AudioOscillatorService,
+    protected componentService: ComponentService,
+    protected configService: ConfigService,
    protected dialog: MatDialog,
-    protected NodeService: NodeService,
-    protected NotebookService: NotebookService,
-    protected StudentAssetService: StudentAssetService,
-    protected StudentDataService: StudentDataService
+    protected nodeService: NodeService,
+    protected notebookService: NotebookService,
+    protected studentAssetService: StudentAssetService,
+    protected studentDataService: StudentDataService


Function with many parameters (count = 9): constructor [qlty:function-parameters]

qltysh · 2025-10-15T17:00:13Z

src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts

  constructor(
-    protected AnnotationService: AnnotationService,
+    protected annotationService: AnnotationService,
    private changeDetector: ChangeDetectorRef,
-    protected ComponentService: ComponentService,
-    protected ConfigService: ConfigService,
-    private ConceptMapService: ConceptMapService,
+    protected componentService: ComponentService,
+    protected configService: ConfigService,
+    private conceptMapService: ConceptMapService,
    protected dialog: MatDialog,
-    protected NodeService: NodeService,
-    protected NotebookService: NotebookService,
-    private ProjectService: ProjectService,
-    protected StudentAssetService: StudentAssetService,
-    protected StudentDataService: StudentDataService
+    protected nodeService: NodeService,
+    protected notebookService: NotebookService,
+    private projectService: ProjectService,
+    protected studentAssetService: StudentAssetService,
+    protected studentDataService: StudentDataService


Found 2 issues:

1. Function with many parameters (count = 11): constructor [qlty:function-parameters]

2. Found 24 lines of similar code in 4 locations (mass = 71) [qlty:similar-code]

qltysh · 2025-10-15T17:00:13Z

src/assets/wise5/components/draw/draw-student/draw-student.component.ts

  constructor(
-    protected AnnotationService: AnnotationService,
-    protected ComponentService: ComponentService,
-    protected ConfigService: ConfigService,
+    protected annotationService: AnnotationService,
+    protected componentService: ComponentService,
+    protected configService: ConfigService,
    protected dialog: MatDialog,
-    private DrawService: DrawService,
-    protected NodeService: NodeService,
-    protected NotebookService: NotebookService,
-    private ProjectService: ProjectService,
-    protected StudentAssetService: StudentAssetService,
-    protected StudentDataService: StudentDataService
+    private drawService: DrawService,
+    protected nodeService: NodeService,
+    protected notebookService: NotebookService,
+    private projectService: ProjectService,
+    protected studentAssetService: StudentAssetService,
+    protected studentDataService: StudentDataService


Found 2 issues:

1. Function with many parameters (count = 10): constructor [qlty:function-parameters]

2. Found 23 lines of similar code in 4 locations (mass = 66) [qlty:similar-code]

qltysh · 2025-10-15T17:00:13Z

src/assets/wise5/components/embedded/embedded-student/embedded-student.component.ts

  constructor(
-    protected AnnotationService: AnnotationService,
+    protected annotationService: AnnotationService,
    private changeDetectorRef: ChangeDetectorRef,
-    protected ComponentService: ComponentService,
-    protected ConfigService: ConfigService,
+    protected componentService: ComponentService,
+    protected configService: ConfigService,
    protected dialog: MatDialog,
-    private EmbeddedService: EmbeddedService,
-    protected NodeService: NodeService,
-    protected NotebookService: NotebookService,
-    private saniztizer: DomSanitizer,
-    protected StudentAssetService: StudentAssetService,
-    protected StudentDataService: StudentDataService
+    private embeddedService: EmbeddedService,
+    protected nodeService: NodeService,
+    protected notebookService: NotebookService,
+    private sanitizer: DomSanitizer,
+    protected studentAssetService: StudentAssetService,
+    protected studentDataService: StudentDataService


Found 2 issues:

1. Function with many parameters (count = 11): constructor [qlty:function-parameters]

2. Found 24 lines of similar code in 4 locations (mass = 71) [qlty:similar-code]

qltysh · 2025-10-15T17:00:13Z

src/assets/wise5/components/graph/graph-student/graph-student.component.ts

  constructor(
-    protected AnnotationService: AnnotationService,
+    protected annotationService: AnnotationService,
    private changeDetectorRef: ChangeDetectorRef,
-    protected ComponentService: ComponentService,
-    protected ConfigService: ConfigService,
+    protected componentService: ComponentService,
+    protected configService: ConfigService,
    protected dialog: MatDialog,
-    private GraphService: GraphService,
-    protected NodeService: NodeService,
-    protected NotebookService: NotebookService,
-    private ProjectService: ProjectService,
-    protected StudentAssetService: StudentAssetService,
-    protected StudentDataService: StudentDataService
+    private graphService: GraphService,
+    protected nodeService: NodeService,
+    protected notebookService: NotebookService,
+    private projectService: ProjectService,
+    protected studentAssetService: StudentAssetService,
+    protected studentDataService: StudentDataService


Found 2 issues:

1. Function with many parameters (count = 11): constructor [qlty:function-parameters]

2. Found 24 lines of similar code in 4 locations (mass = 71) [qlty:similar-code]

qltysh · 2025-10-15T17:00:13Z

...ssets/wise5/components/openResponse/open-response-student/open-response-student.component.ts

  constructor(
-    protected AnnotationService: AnnotationService,
+    protected annotationService: AnnotationService,
    private changeDetector: ChangeDetectorRef,
-    protected ComponentService: ComponentService,
+    protected componentService: ComponentService,
    private constraintService: ConstraintService,
-    protected ConfigService: ConfigService,
+    protected configService: ConfigService,
    private cRaterPingService: CRaterPingService,
-    private CRaterService: CRaterService,
+    private cRaterService: CRaterService,
    protected dialog: MatDialog,
-    private OpenResponseService: OpenResponseService,
-    protected NodeService: NodeService,
-    protected NotebookService: NotebookService,
-    private NotificationService: NotificationService,
-    private ProjectService: ProjectService,
-    protected StudentAssetService: StudentAssetService,
-    protected StudentDataService: StudentDataService
+    private openResponseService: OpenResponseService,
+    protected nodeService: NodeService,
+    protected notebookService: NotebookService,
+    private notificationService: NotificationService,
+    private projectService: ProjectService,
+    protected studentAssetService: StudentAssetService,
+    protected studentDataService: StudentDataService


Function with many parameters (count = 15): constructor [qlty:function-parameters]

qltysh · 2025-10-15T17:00:14Z

src/assets/wise5/components/outsideURL/outside-url-student/outside-url-student.component.ts

  constructor(
-    protected AnnotationService: AnnotationService,
-    protected ComponentService: ComponentService,
-    protected ConfigService: ConfigService,
+    protected annotationService: AnnotationService,
+    protected componentService: ComponentService,
+    protected configService: ConfigService,
    protected dialog: MatDialog,
-    protected NodeService: NodeService,
-    protected NotebookService: NotebookService,
+    protected nodeService: NodeService,
+    protected notebookService: NotebookService,
    protected sanitizer: DomSanitizer,
-    protected StudentAssetService: StudentAssetService,
-    protected StudentDataService: StudentDataService
+    protected studentAssetService: StudentAssetService,
+    protected studentDataService: StudentDataService


Function with many parameters (count = 9): constructor [qlty:function-parameters]

qltysh · 2025-10-15T17:00:14Z

src/assets/wise5/components/table/table-student/table-student.component.ts

  constructor(
-    protected AnnotationService: AnnotationService,
+    protected annotationService: AnnotationService,
    private changeDetectorRef: ChangeDetectorRef,
-    protected ComponentService: ComponentService,
-    protected ConfigService: ConfigService,
+    protected componentService: ComponentService,
+    protected configService: ConfigService,
    protected dialog: MatDialog,
-    protected NodeService: NodeService,
-    protected NotebookService: NotebookService,
-    private ProjectService: ProjectService,
-    protected StudentAssetService: StudentAssetService,
-    protected StudentDataService: StudentDataService,
-    private TableService: TableService,
-    private TabulatorDataService: TabulatorDataService
+    protected nodeService: NodeService,
+    protected notebookService: NotebookService,
+    private projectService: ProjectService,
+    protected studentAssetService: StudentAssetService,
+    protected studentDataService: StudentDataService,
+    private tableService: TableService,
+    private tabulatorDataService: TabulatorDataService


Found 2 issues:

1. Function with many parameters (count = 12): constructor [qlty:function-parameters]

2. Found 25 lines of similar code in 2 locations (mass = 76) [qlty:similar-code]

qltysh · 2025-10-15T17:00:14Z

...se5/themes/default/notebook/edit-notebook-item-dialog/edit-notebook-item-dialog.component.ts

  constructor(
+    private assetService: StudentAssetService,
    private configService: ConfigService,
    @Inject(MAT_DIALOG_DATA) public data: any,
    private dialogRef: MatDialogRef<EditNotebookItemDialogComponent>,
    private fb: FormBuilder,
-    private projectService: ProjectService,
-    private studentAssetService: StudentAssetService
+    private projectService: ProjectService


Function with many parameters (count = 6): constructor [qlty:function-parameters]

hirokiterashima · 2025-11-17T18:47:50Z

🎉 This PR is included in version 5.199.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

hirokiterashima added 12 commits October 9, 2025 16:22

Convert component student to standalone

e241b13

self close add-to-notebook-button element

3752871

Lower case variable names

681687a

Remove PeerChatStudentModule

bae25fa

Convert VLEParentComponent to standalone

0387c46

Convert StudentAccountMenuComponent to standalone and clean up relate…

f5c4bb2

…d files

Convert WISELinkComponent to standalone and clean up related files

f3e70ac

Convert DismissAmbientNotificationDialogComponent to standalone and c…

44611d4

…lean up related files

Convert dialogs to standalone and clean up related files

5b0711f

Convert DragAndDropDirective to standalone and clean up related files

2c7cb8a

Convert EditNotebookItemDialogComponent to standalone and clean up re…

659e64f

…lated files

Convert GenerateImageDialogComponent to standalone. Needed to change …

fe7e4d5

…so it is opened by messages, instead of function call in ComponentStudentComponent because this was causing circular dependency

hirokiterashima added this to the Standalone Components milestone Oct 15, 2025

hirokiterashima self-assigned this Oct 15, 2025

hirokiterashima added the Code Quality label Oct 15, 2025

hirokiterashima changed the title ~~refactor(VLE): Convert to standalone~~ refactor(VLE): Convert all components to standalone Oct 15, 2025

qltysh bot reviewed Oct 15, 2025

View reviewed changes

hirokiterashima marked this pull request as ready for review October 15, 2025 18:01

hirokiterashima merged commit e792d7c into develop Oct 15, 2025
4 checks passed

hirokiterashima deleted the convert-wise5-componenents-to-standalone branch October 15, 2025 20:09

hirokiterashima added the released label Nov 17, 2025

refactor(VLE): Convert all components to standalone #2241

refactor(VLE): Convert all components to standalone #2241

Uh oh!

Conversation

hirokiterashima commented Oct 15, 2025

Changes

Test

Uh oh!

qltysh bot commented Oct 15, 2025

❌ 23 blocking issues (23 total)

Uh oh!

qltysh bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hirokiterashima commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants