-
Notifications
You must be signed in to change notification settings - Fork 2
Add platform-specific user agents for iOS/Android streams #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
11
commits into
develop
Choose a base branch
from
copilot/add-user-agent-to-tracks
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
46a48d3
Initial plan
Copilot 4da9548
Add distinct user agents for iOS/Android streams
Copilot f80a51c
Derive app version from package.json instead of hardcoding
Copilot 79055f1
Merge branch 'main' into copilot/add-user-agent-to-tracks
jsit 82878d2
style: lint
jsit 23a6a98
style: lint
jsit 3ad8ed5
Merge branch 'main' into copilot/add-user-agent-to-tracks
jsit 055a17a
Merge remote-tracking branch 'origin/main' into copilot/add-user-agen…
jsit 9153fb4
fix: fix syntax error in tsconfig
jsit 559213a
Merge branch 'main' into copilot/add-user-agent-to-tracks
jsit b5c9048
fix: fix and simplify user agent tests
jsit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { Platform } from 'react-native'; | ||
| import { getUserAgent } from '../src/utils/UserAgent'; | ||
|
|
||
| // Mock Platform from react-native | ||
| jest.mock('react-native', () => ({ | ||
| Platform: { | ||
| OS: 'ios', | ||
| Version: '17.0', | ||
| }, | ||
| })); | ||
|
|
||
| describe('getUserAgent', () => { | ||
| afterEach(() => { | ||
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| test('should return iOS user agent when platform is iOS', () => { | ||
| (Platform as any).OS = 'ios'; | ||
| (Platform as any).Version = '17.0'; | ||
|
|
||
| const userAgent = getUserAgent(); | ||
|
|
||
| expect(userAgent).toBe('WMBRApp/0.0.1 (iOS; iPhone)'); | ||
| }); | ||
|
|
||
| test('should return Android user agent when platform is Android', () => { | ||
| (Platform as any).OS = 'android'; | ||
| (Platform as any).Version = 33; | ||
|
|
||
| const userAgent = getUserAgent(); | ||
|
|
||
| expect(userAgent).toBe('WMBRApp/0.0.1 (Android; SDK 33)'); | ||
| }); | ||
|
|
||
| test('should include correct SDK version for Android', () => { | ||
| (Platform as any).OS = 'android'; | ||
| (Platform as any).Version = 30; | ||
|
|
||
| const userAgent = getUserAgent(); | ||
|
|
||
| expect(userAgent).toContain('SDK 30'); | ||
| }); | ||
|
|
||
| test('should always include app version in user agent', () => { | ||
| const iosUserAgent = getUserAgent(); | ||
| expect(iosUserAgent).toContain('WMBRApp/0.0.1'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { Platform } from 'react-native'; | ||
|
|
||
| /** | ||
| * Generates a platform-specific user agent string for HTTP requests. | ||
| * This helps servers identify iOS vs Android clients. | ||
| * | ||
| * Format: WMBRApp/{version} ({platform}; {os}) | ||
| * Examples: | ||
| * - "WMBRApp/0.0.1 (iOS; iPhone)" | ||
| * - "WMBRApp/0.0.1 (Android; SDK 33)" | ||
| */ | ||
| export function getUserAgent(): string { | ||
| const version = '0.0.1'; // Should match package.json version | ||
| const osVersion = Platform.Version; | ||
|
|
||
| if (Platform.OS === 'ios') { | ||
| return `WMBRApp/${version} (iOS; iPhone)`; | ||
| } else { | ||
| return `WMBRApp/${version} (Android; SDK ${osVersion})`; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.