Skip to content

Feature/calculate semantic layer after population#89

Merged
hsauve-scottlogic merged 13 commits intorelease/improve-reliabilityfrom
feature/calculate-semantic-layer-after-population
Sep 6, 2024
Merged

Feature/calculate semantic layer after population#89
hsauve-scottlogic merged 13 commits intorelease/improve-reliabilityfrom
feature/calculate-semantic-layer-after-population

Conversation

@hsauve-scottlogic
Copy link
Collaborator

Description

This PR focuses on calculating the semantic layer dynamically and storing the graph_schema in a cache so it doesn't need to be recalculated when the agent is called again .

Changelog

  • Deletes graph_schema.j2
  • Brings in latest code from Michael Down (Neo4j)
  • Calculates semantic_layer_builder when datastore agent is summoned the first time
  • Stores graph schema in cache

gaganahluwalia
gaganahluwalia previously approved these changes Sep 5, 2024
Copy link
Collaborator

@gaganahluwalia gaganahluwalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@swood-scottlogic swood-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good! I've left a couple of comments, but happy to talk through any of my feedback if you'd prefer :)

gaganahluwalia
gaganahluwalia previously approved these changes Sep 6, 2024
Copy link
Collaborator

@swood-scottlogic swood-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback!

@hsauve-scottlogic hsauve-scottlogic merged commit 1929ddf into release/improve-reliability Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants