Repository navigation
fix(deps): update vulnerable ZIP and TLS dependencies - #459
Closed
2725238326 wants to merge 2 commits into
Closed
2725238326 wants to merge 2 commits into
2725238326 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo auditfails on the locked ZIP and TLS dependencies. This updates zip to 9.0.5, rustls to 0.23.46, rustls-webpki to 0.103.16, and webpki-root-certs to 1.0.10. The archive readers handle ZIP 9's fallible entry-name API.The updater's optional ZIP installer feature retains a separate zip 4.6.1 dependency. Disable that feature: the published Windows update manifest uses signed NSIS
.exefiles. TLS and proxy support stay enabled, and the macOS.app.tar.gzpath does not depend on this feature. Legacy zipped Windows installers are no longer supported.The download test now checks that
file://is rejected by the existing HTTPS-only policy, rather than expecting a successful transfer. Production download arguments are unchanged.Validation
On Windows, workspace tests pass (436 passed, 17 existing ignored tests), as does Clippy with warnings denied. Frontend checks, lint, all 475 tests and the build pass. All three npm lockfile audits report no vulnerabilities.
cargo auditreports no vulnerabilities, andcargo deny checkpasses. Archive tests cover CP437 filenames, path validation, size limits and theme import.