Skip to content

ci: add pull-request checks (type-check, tests, clippy, cargo test) - #9

Merged
Wangnov merged 1 commit into
mainfrom
ci/pull-request-checks
Jun 7, 2026
Merged

Wangnov merged 1 commit into
mainfrom
ci/pull-request-checks

Conversation

@Wangnov

@Wangnov Wangnov commented Jun 7, 2026

Copy link
Copy Markdown
Owner

Adds a fast CI gate that runs on every PR and on pushes to `main`, separate from the existing tag-driven `release.yml` (which is the only workflow today and never runs on PRs).

Jobs

  • Frontend (ubuntu): `npm ci` → `tsc --noEmit` → `vitest` (via `npm run test --if-present`) → `vite build`.
  • Rust (macos-latest + windows-latest): build the frontend first so `tauri-build`'s `frontendDist: ../dist` resolves, then `cargo clippy --workspace --all-targets -- -D warnings` and `cargo test --workspace`.

Notes

  • Deliberately does not run `tauri build` — no bundling, signing or notarization. That stays in `release.yml`.
  • `rustfmt --check` is intentionally omitted for now: some pre-existing example bins under `crates/*/src/bin` are unformatted and would fail the gate on arrival.
  • Verified locally on macOS: workspace `cargo test` and `cargo clippy -D warnings` are clean; `tsc`, vitest (11 tests) and `vite build` all pass.

Once this is green it can be wired in as a required status check on the `main` ruleset.

Adds a fast PR/main gate separate from the tag-driven release pipeline:
- frontend: tsc --noEmit, vitest (--if-present), vite build (ubuntu)
- rust: clippy -D warnings + cargo test on the workspace (macos + windows)

The Rust jobs build the frontend first so tauri-build's frontendDist (../dist)
resolves, but never run `tauri build` — no bundling, signing or notarization
happens here. rustfmt --check is intentionally omitted for now (pre-existing
example bins under crates/*/src/bin are unformatted).
@Wangnov
Wangnov merged commit 21c132c into main Jun 7, 2026
3 checks passed
@Wangnov
Wangnov deleted the ci/pull-request-checks branch June 7, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant