[TASK] Add support for HTTP proxies #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If TYPO3 is configured to use a proxy server for outgoing traffic, the API requests to cleverreach will fail. With this patch, the proxy server configured in TYPO3 install tool will be used for all curl requests. On a long run, it will be better to get rid of the custom implemenation for HTTP requests and use Guzzle (bundled in TYPO3 Core since V8) instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If TYPO3 is configured to use a proxy server for outgoing traffic,
the API requests to cleverreach will fail.
With this patch, the proxy server configured in TYPO3 install tool
will be used for all curl requests.
On a long run, it will be better to get rid of the custom implementation
for HTTP requests and use Guzzle (bundled in TYPO3 Core since V8)
instead.